Adrien Grand
Adrien Grand
Would you like to make this PR up-to-date and open a new one for the other change (a cherry-pick isn't clean due to other changes)?
@javanna just fixed it, thanks @javanna !
Is it possible to disable this check based on files that are touched (e.g. test-only fixes don't require a changelog entry) and based on the presence of a label (e.g....
If filtered performance is critical, then I wonder if there could be better ways, e.g. using a vector search algorithm from the IVF family instead of HNSW, and configuring an...
IMO Lucene should own how queries execute concurrently instead of making it pluggable. So I'd rather not allow users to pass a custom `TaskExecutor`.
Can you link the paper that you implemented? I'll need some time to digest these 5k lines. :)
> the implementation is more ambitious I like ambition, but it also makes this change harder to review/integrate, especially with the high LOC count. I would suggest splitting this PR...
To add to @vigyasharma, I have been wondering if we should remove `SearcherManager` and encourage users to use `IndexReaderManager`. `IndexSearcher` is cheap to create and there are som reasons why...
The fact that the index is small rules out an overflow I suppose. I'm not familiar with this flavor of the JDK, are you able to test with another vendor...
I don't see an obvious solution either. My preference would be to remove the cache and make this decision on a per-segment basis, but this would require moving some methods...