Adrien Grand
Adrien Grand
@yossev FYI you'll need to resolve conflicts since another change touched the same lines of code. I'm curious if you had any success with benchmarking?
@yossev see the output of the build failure, the build is unhappy with formatting, you need to run `./gradlew tidy`. Have you had any success with benchmarking?
> Is there a good reason to not have this ring buffer tracking at a per segment level? To your point, there are many segments, so this would increase heap...
I agree that it may not be much. I still like fixing `AbstractMultiTermQueryConstantScoreWrapper` better?
I was wondering about a variant of your idea that would consist of not reusing the provided `IndexSearcher` but creating a private one that doesn't cache (`IndexSearcher#setQueryCache(null)`). Let's discuss implementation...
I'm not worried about this. If we feel like we should expose it differently in the future, we'll do it, deprecate this function, and remove it in Lucene 11.
@harenlin I took some freedom to apply my feedback and push it to your branch. Would you like to take a look and check if it makes sense?
I plan on merging this PR soon if there are no objections.
Thanks for taking a look. I have a bias for the latter, as I was planning on improving the docs of the oal.search package as a follow-up to provide guidance...
> I have a bias for the latter, as I was planning on improving the docs of the oal.search package as a follow-up to provide guidance wrt how to do...