lucene icon indicating copy to clipboard operation
lucene copied to clipboard

Replace Map<String,Object> with IntObjectHashMap for KnnVectorsReader

Open bugmakerrrrrr opened this issue 1 year ago • 7 comments

Description

Following up on #13686.

bugmakerrrrrr avatar Sep 11 '24 13:09 bugmakerrrrrr

@benwtrent @jpountz I have merged main branch into this one, can I get a review on this?

bugmakerrrrrr avatar Sep 13 '24 15:09 bugmakerrrrrr

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!

github-actions[bot] avatar Oct 04 '24 00:10 github-actions[bot]

hi @jpountz ,since we have moved to lucene 10, should we merge this and add back #13686?

bugmakerrrrrr avatar Oct 14 '24 11:10 bugmakerrrrrr

Yes, let's add this in 10.1.

jpountz avatar Oct 15 '24 14:10 jpountz

Would you like to make this PR up-to-date and open a new one for the other change (a cherry-pick isn't clean due to other changes)?

jpountz avatar Oct 15 '24 14:10 jpountz

Would you like to make this PR up-to-date and open a new one for the other change (a cherry-pick isn't clean due to other changes)?

@jpountz sure, I‘d be happy to do this.

bugmakerrrrrr avatar Oct 15 '24 15:10 bugmakerrrrrr

@jpountz I have merged main branch, PTAL:)

bugmakerrrrrr avatar Oct 16 '24 13:10 bugmakerrrrrr