Adrien Grand

Results 310 comments of Adrien Grand

> I'd like to get this tool merged Some API changes are a bit annoying, e.g. the fact that `KnnVectorsReader` now has an API that is specific to HNSW. I'm...

> There are at most 2 segment tiers. Well, there can be more tiers, but since tiers have exponential sizes (e.g. if you merge factor is 10, each tier has...

I spent some time digging into the new behavior introduced by this PR, as I'd like to get it over the finish line. :) I am getting disappointing results for...

@carlosdelest I took the freedom of pushing some changes to your fork, I hope you don't mind!

FWIW I have been playing with `BaseMergePolicyTestCase`'s `doTestSimulateAppendOnly` and `doTestSimulateUpdates`. With this change, I'm observing a number of segments in the order of `targetSearchConcurrency` on the highest tier while increasing...

Thanks for checking, I misremembered. @uschindler +1 to disallowing clones and slices. I' m contemplating making `MockDirectoryWrapper` also fail if `IndexInput`s get used in a different thread from the one...

>> I'm contemplating making MockDirectoryWrapper also fail if IndexInputs get used in a different thread from the one where they were created. > > You mean this for READONCE ones,...

See `BooleanQuery#clauseSets`, which is used for equals()/hashcode() and `BooleanQuery#clauses`, which is used for toString().

I wouldn't sort them, and just rely on the order that the caller supplied?