lucene icon indicating copy to clipboard operation
lucene copied to clipboard

Published 20 hours ago • verified publisher icon apache

Convert more classes to record classes

Open shubhamvishu opened this issue 1 year ago • 8 comments

Description

  • This PR addresses #13207 to convert more classes on main branch to record classes on main (Lucene 10 only).
  • It moves a lot of data classes(120 to be precise) to use record classes that were flagged suitable in my IDE and seemed good candidate in general.
  • I left a couple of them like TotalHits and SynonymMap as the PR is already very big and including those were leading to a lot more changes. Maybe we could do those as a separate PR.

  Raising this PR since all the tests are passing(./gradlew test) but renderJavadoc task is complaining about missing java docs on some record classes(converted in this PR) which I see has the javadocs already eg: TermStats, ReaderSlice. I'm not sure why its flagging those incorrectly or if maybe I'm missing something.

shubhamvishu avatar Apr 30 '24 02:04 shubhamvishu