Jon Parise

Results 147 comments of Jon Parise

Can you saw more about why that component should be package separately? Or is this more about the fact that we haven't published any of the new 2.0 stuff as...

> @jparise I'm curious why those reserved words are reserved. What was the idea behind them? This is borrowed from Apache Thrift. The idea is that Thrift IDL shouldn't contain...

Is this related to https://github.com/pinterest/elixometer/pull/114#issuecomment-412920521?

That sounds useful to me. How would errors propagate?

It could be nice to support just `use Thrift.Service`. I like being explicit about the aliases, but we could perhaps extend to `use` statement to make that shorter: ```elixir use...

This makes good sense to me. I like the pipeline-based model, and I appreciate the testing benefits we'll see as a result of this (re)organization. I don't think we'll see...

If we agree on this approach, should we also include this in the [2.0 milestone](https://github.com/pinterest/elixir-thrift/milestone/1)?

@fishcakez are you suggesting we pull this into the [2.0 milestone](https://github.com/pinterest/elixir-thrift/milestone/1)?

> Having to use `%Thrift.Protocol.Binary{}` to wrap binaries everywhere is awkward Yes, I can see that, but I agree with your overall conclusion that this is still the best multi-protocol...

> Is there a way to not have the abort() function output HTML? Yes, that's where the `errorhandler` bit comes in: ```py @app.errorhandler(404) def not_found(error): message = { 'status': error.status_code,...