Jon Parise

Results 147 comments of Jon Parise

One bit of prior art: https://github.com/gjaldon/ecto_enum

I think it's particularly helpful to keep in mind that, in Thrift, enumerated values are _always_ integers (`i32`), as they are in C. We don't need to design a solution...

Note that as long as we’re generating macros, we have to worry about name classes with the `meta`, `name`, and `value` functions.

I would like to add support for having the compiler task write a "manifest" that would track its generated files. That would gives us a mechanism to clean and regenerate...

> Where would the manifest file reside, the project root? The convention is to use `Mix.Project.manifest_path`, which falls under `_build/{env}/`. The fact that it's environment-specific might require some thought, but...

We now determine "staleness" based on a manifest version and the package's version. This should work well for most users once we ship regular releases, but during development the package...

I looked into including the git revision in the manifest header. It's a little bit trickier than I expected, but it's definitely possible. After hunting around the mix code a...

> @jparise is it enough to add: > > > The `:reconnect` option if setted to `true` forces client to reopen tcp connection whenever it closed. `s/setted/set` > as a...

I think this is the right direction for the parser and generation. I'll own this for the time being, but I don't expect to work on it until at least...

I like this idea and spent a little time looking into a possible implementation. It unfortunately doesn't appear to be an easy thing to build, however. Because structs are just...