Jon Parise
Jon Parise
I'll also acknowledge that some larger refactoring exercises are in order, such as passing Builder objects through these calls instead of reified structs. Please take the above primarily in terms...
As an incremental improvement, #250 adds an explicit `@NonNull` annotation.
@maralla and @hit9, do you think this is something you'd consider for review and merging? It's an old Thrift feature, but we have some `.thrift` files that rely on it,...
@maralla and @hit9, just wanted to follow-up and ask if this is still under consideration.
Sorry to bother @lxyu @hit9 @maralla, but would you consider merging this?
I'm seeing some of the issues that @pguillory mentions in the previous comment with the current approach to generating constants. Start with a file named `userservice.thrift` that includes some constants...
It's not thing we use, so it's unlikely we'll implement it. Next on the list is ThriftMux support, perhaps followed by Thrift Compact Binary.
I've been tracking progress using the [2.0 milestone](https://github.com/pinterest/elixir-thrift/milestone/1). We're pretty close to having something ready to release in an alpha/beta state, but any feedback or testing would be very much...
Also, a little more detail in case it's helpful: The 1.x line was a simple wrapper around the Apache Thrift Erlang library and required integration with the `thrift` compiler tool....
The 2.x master code is actively in-use within Pinterest. We've unfortunately just been distracted from putting together a fully documented, etc. 2.x release. The next move might be to take...