Jon Parise comments

Results 147 comments of


                                            Jon Parise

Markdown linting

Fix alwaysHandleTruncationTokenTap

@ay8s have any luck looking into tests for this?

Fix alwaysHandleTruncationTokenTap

> @jparise Got halfway there, would love to perhaps pair in Slack how best to tackle testing this. Seems something could be added to both ASTextNode and ASTextNode2. I think...

Fix alwaysHandleTruncationTokenTap

@ay8s have you gotten a chance to sync on the best way to write a test for this?

Fix alwaysHandleTruncationTokenTap

@ay8s looks like it's just the CLA check which is blocking this. Mind signing that?

[ASNetworkImageNode] For GIFs, imageNode:didLoadImage:info is not called.

@yang152412 would you mind rebasing this PR?

Times should be stored as `time.Time`

I think that would be a good improvement. Any opinion, @cgordon?

dhcpv4: switch to nclient4

I'm going to pass this on to @jogo or one of the other Pinterest folks to review.

gRPC Support

Nothing planned on our end, but we’d be happy to accept a contribution that adds gRPC support.

Where to from here:

I think the area in need of the most work is determining the current state of the project. What combination of Python and PHP versions actually work (see #9)? And...