Jon Parise

Results 147 comments of Jon Parise

This is similar to #82, which proposes something similar (glob support) to `ignore-names`.

I think we could make an exception to N806 for single-letter variable names. It would also be easy to implement. What do the other @PyCQA/pep8-naming-dev folks think about this?

> * use per-line disabling like `X = 3 # noqa: N806` in codebases where it is uncommon This suggestion unfortunately isn't great for function argument names, which are relevant...

@elprans do you have any initial thoughts on how to approach this?

It should work as you expect, so we'll need to debug the issue. Are you using any plugins that extend vim's basic JavaScript behavior?

I just verified that this is working (for me and in the unit tests) in both vim 9.0 and neovim 0.7.2, so it feels like something in your configuration is...

This is the root issue: > `indentexpr=nvim_treesitter#indent()` It's preventing the vim-graphql plugin from injecting its own indentation function, which happens here: https://github.com/jparise/vim-graphql/blob/4bf5d33bda83117537aa3c117dee5b9b14fc9333/after/indent/javascript.vim#L32-L33 I don't have a solution for that at...

> * indentation is not inserted at the first line within `` (I.e. line2.). This is the current expected behavior. It's due to the fact that we're embedding the GraphQL...

I don't have Python 3.5 handy, but it appears to exist in Python 3.6: ``` Python 3.6.3 (default, Oct 4 2017, 06:09:15) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.37)] on...

Maybe this should require Thrift 0.10 in mix.exs (via `thrift_version`). The `.travis.yml` script will also need to an update to use Thrift 0.10 in the CI environment.