react
react copied to clipboard
fix(Checkbox): mirror `aria-checked` to checked property of checkbox input
Closes https://github.com/primer/react/issues/4262
Changelog
New
Changed
- Mirror the
aria-checkedattribute to thecheckedproperty on the checkbox input
Removed
Rollout strategy
- [x] Patch release
Testing & Reviewing
- [ ] Verify that the axe issue from the original issue is no longer present
- [ ] Do you have any ideas for better handling this change? 👀 Unfortunately,
defaultCheckedwas the root of the issue here and I couldn't think of a better way to keep things in sync since this component can be both controlled and uncontrolled
🦋 Changeset detected
Latest commit: 7aff51a0850eda14b8f4b998b9c34dc8d77f8134
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @primer/react | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
size-limit report 📦
| Path | Size |
|---|---|
| packages/react/dist/browser.esm.js | 113.53 KB (+0.04% 🔺) |
| packages/react/dist/browser.umd.js | 114.2 KB (+0.04% 🔺) |
bump @pksjce if you have a sec to review!