react icon indicating copy to clipboard operation
react copied to clipboard

fix(Checkbox): mirror `aria-checked` to checked property of checkbox input

Open joshblack opened this issue 1 year ago • 3 comments

Closes https://github.com/primer/react/issues/4262

Changelog

New

Changed

  • Mirror the aria-checked attribute to the checked property on the checkbox input

Removed

Rollout strategy

  • [x] Patch release

Testing & Reviewing

  • [ ] Verify that the axe issue from the original issue is no longer present
  • [ ] Do you have any ideas for better handling this change? 👀 Unfortunately, defaultChecked was the root of the issue here and I couldn't think of a better way to keep things in sync since this component can be both controlled and uncontrolled

joshblack avatar Feb 12 '24 18:02 joshblack

🦋 Changeset detected

Latest commit: 7aff51a0850eda14b8f4b998b9c34dc8d77f8134

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 12 '24 18:02 changeset-bot[bot]

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 113.53 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js 114.2 KB (+0.04% 🔺)

github-actions[bot] avatar Feb 12 '24 18:02 github-actions[bot]

bump @pksjce if you have a sec to review!

joshblack avatar Feb 20 '24 18:02 joshblack