Jon Atack

Results 455 comments of Jon Atack

Closing for now in favor of #1555 that replaces BIP21, happy to re-open if requested.

> For anyone who's interested, I'm hosting a review club meeting about this PR on Wednesday: [bitcoincore.reviews/32489](https://bitcoincore.reviews/32489) There is `Review Club` label in this repo that can be added, too.

Yes, it's nice that the check is working now. Here's the entry it suggests: ``` +> | [[bip-0388.mediawiki|388]] +> | Applications +> | Wallet Policies for Descriptor Wallets +> |...

> make getpeerinfo accept a peer id param to just investigate that one Sounds useful. Didn't re-read the discussion, but I'm not sure that no connection should throw, in favor...

@reardencode per your question in https://github.com/bitcoin/bips/pull/1535#issuecomment-2111195930 and above, the current process is that of BIP 2. Iteration while in Draft status seems to be expected, but a BIP may only...

The red CI is an unrelated timeout. I'm still adapting to the new build system, but fwiw, locally it looks like no unit tests fail if I flip the changed...

re-ACK fc7b507e9a595a7bf91f4e0f42b4d842af8b93f3 only change since my previous ACK is the commit message

Thanks everyone, updated to take all feedback.