John Blackbourn comments

Results 494 comments of


                                            John Blackbourn

Don't truncate the list of events on any given day

Previously: cf516c7f7ab697400b4cd4cba01f5d32e013bdc8

Try adding keytar to store credentials

> This needs testers on Windows and Linux. Pinging @kadamwhite @azaozz @SergeyBiryukov

Enterprise Growth Council improvements

LGTM 👍

Enterprise Growth Council improvements

Alright this is ready for final review. I have some further improvements lined up but they can be done in a follow up PR.

Clarify and/or correct section about SSRF

Ah yes, I think you're right. Needs some clarification.

Do we need a whitepaper PDF at all?

I concur that having the PDF included in the repo is a pain for maintainability. It should either be removed completely or we should add a build step which generates...

Update latest version of WP and updated date

This will be fixed by #71.

Section on escaping and sanitization functions

Yeah let's link out to them instead

Enable client side modern image generation

Ancient core Trac ticket on this topic: https://core.trac.wordpress.org/ticket/19770

Parse array parameter docs

Looks like this was fixed at some point, but I'm not sure where, and I can't see any test coverage for it. Is there some post-processing happening on developer.wordpress.org? For...