John Blackbourn

Results 495 comments of John Blackbourn

Hopefully all of these instances have now been removed from core. See https://core.trac.wordpress.org/ticket/35974.

I'm pretty sure the parser only works on PHP 7 at the moment. See #228.

Looks like this is no longer an issue.

I'll take a look at what's happening in QM. I would recommend testing this out with some multilingual plugins if you haven't already. In particular WPML (and add-on plugins for...

I'm not seeing an infinite loop in my local testing with RTL Tester. I am concerned about calling `__()` from within the load textdomain functions though. Do we do that...

Good spot, thanks. Temporarily unhooking itself is probably best otherwise there's no way to know what else might trigger a `_doing_it_wrong` call within any of the functions that are called...

This could be noisy but it might be interesting to see if any feedback about that is raised during beta.

https://core.trac.wordpress.org/changeset/58107

https://core.trac.wordpress.org/changeset/58108