John Blackbourn comments

Results 495 comments of


                                            John Blackbourn

Bad types into WP_Post class

It's just occurred to me that the default value is the incorrect type: ```php public $post_author = 0; ``` I'll have a dig around in WordPress core and see if...

composer - prevent updating unnecessary dependencies - ability to set `setWhitelistTransitiveDependencies(false)`

I think this is a duplicate of #3592

Introduce file ignorance for Composer distributions of packages

I went through all the commands, and this is what I've got: ``` * text=auto .distignore export-ignore .editorconfig export-ignore .gitattributes export-ignore .github export-ignore .gitignore export-ignore .mailmap export-ignore .travis.yml export-ignore behat.yml...

Introduce file ignorance for Composer distributions of packages

Yep let's ignore `wp-cli.yml`. I didn't see a repo containing `phpcs.xml`. If there is one, then let's ignore that too. I didn't ignore `CONTRIBUTING.md`, `README.md`, and `LICENSE` mostly because I...

Double escaped SSH commands

It doesn't cause a problem, but it's also not ideal. A program should be aware of the correct places to apply appropriate escaping, not apply escaping just in case.

Filter for the values that appear in auto-suggest search

I have a partially completed fix for this which I started a while ago. It also tidies up the JS for the auto-suggest field. I'll get it finished up and...

Filter for the values that appear in auto-suggest search

That code is long gone, sorry!

get_media_items params are optional

Neither of these parameters are optional, this is a bug in the documentation in WordPress core.

Detect wrong type used with `new`

Playground link: https://phpstan.org/r/008a73ff-e4cc-4865-b073-ca04cd00a3d0

PHP 8: Detect parameter name changes in methods

I updated the Playground link with a more complete example.