Jenn Magder

Results 592 comments of Jenn Magder
trafficstars

For example, to fix https://github.com/flutter/flutter/issues/29052 we would have to explicitly exclude directories prepended with `.`.

@cyanglaz points out this was already reviewed in https://github.com/flutter/plugins/pull/5102, this LGTM.

This should be rebased onto https://github.com/flutter/plugins/pull/6237. Or closed and let dependabot open another on the next version.

Looks like this also needs a rebase onto the `in_app_purchase_storekit` changes on top of tree.

@fengyuxx friendly bump, @cyanglaz had some requested changes on this PR. @mvanbeusekom were your requested changes addressed?

@fengyuxx This is ready to merge, would you mind fixing up the version and CHANGELOG conflict?

Is the only thing remaining here the CHANGELOG issue? @KosukeSaigusa can you rebase/merge onto top of tree and make sure your pubpsec and CHANGELOG version matches?

Friendly ping, @KosukeSaigusa, this is so close to being mergeable! 🙂

You were the first to notice this, you must be on top of tree in the flutter SDK https://github.com/flutter/flutter/issues/104453. That shouldn't impact your tests in this PR, please ignore any...

@GaryQian @camsim99 @cyanglaz would you mind giving this another look?