plugins
plugins copied to clipboard
[webview_flutter_wkwebview] Fix typo of a method name, setCookieForInsances
Just fixed a typo of a method name, from setCookieForInsances
to setCookieForInstances
No version change: Only updates internal method name.
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use
dart format
.) - [x] I signed the CLA.
- [x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g.
[shared_preferences]
- [x] I listed at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [x] I updated
CHANGELOG.md
to add a description of the change, following repository CHANGELOG style. - [x] I updated/added relevant documentation (doc comments with
///
). - [x] I added new tests to check the change I am making, or this PR is test-exempt.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).
If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?
Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.
Hi @KosukeSaigusa, thanks for fixing this.
Could you updated the CHANGELOG by following: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#updating-a-changelog-that-has-a-next.
Thank you for your message, @bparrishMines. Now I updated the CHANGELOG.md in this commit: https://github.com/flutter/plugins/pull/6102/commits/cec0ebcbc33ce08a6a75c95c10edeb5ca7f9371b
@bparrishMines Thank you. Resolved the conflict and updated the grammar.
Is the only thing remaining here the CHANGELOG issue? @KosukeSaigusa can you rebase/merge onto top of tree and make sure your pubpsec and CHANGELOG version matches?
Friendly ping, @KosukeSaigusa, this is so close to being mergeable! 🙂