Jenn Magder
Jenn Magder
@hellohuanlin is this ready to land?
> But picture in picture is done by the OS itself. I'm not sure how I should test it in a UI test that it does work, other than how...
> Reviewers can provide feedback on whether there are additional elements that should be tested. @stuartmorgan does that mean this is ready for review?
cc @hellohuanlin
@hellohuanlin can you take another look at this, if your changes have all been addressed?
@loic-sharma this still needs Windows review. @ditman you were marked as the camera_web codeowner, did you remove yourself as a reviewer? Not sure how that disappeared.
> > introspecting the file uniform type identifier, > > @jmagman which API are you referring to? I found this NSURL API but it's only for local resources. > >...
``` /var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/packages/video_player/video_player_avfoundation/example/ios/RunnerUITests/VideoPlayerUITests.m:101: error: -[VideoPlayerUITests testEncryptedVideoStream] : ((frames.count >= 3) is true) failed - Must have at least 3 distinct frames. ``` Unfortunately we can't get the attachments off of Cirrus...
> ``` > /var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/packages/video_player/video_player_avfoundation/example/ios/RunnerUITests/VideoPlayerUITests.m:101: error: -[VideoPlayerUITests testEncryptedVideoStream] : ((frames.count >= 3) is true) failed - Must have at least 3 distinct frames. > ``` > > Unfortunately we can't get...