Jenn Magder
Jenn Magder
https://fuchsia.googlesource.com/third_party clones failed? @CaseyHillers what's up here?
> @cyanglaz could you push an empty commit to rerun tests. I re-ran manually 🤞
``` /Volumes/Work/s/w/ir/cache/goma/client/gomacc ../../buildtools/mac-x64/clang/bin/clang++ -MD -MF obj/flutter/shell/platform/darwin/ios/framework/Source/flutter_framework_source.FlutterTextInputPlugin.o.d -DFLUTTER_FRAMEWORK=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DSHELL_ENABLE_SOFTWARE -DSHELL_ENABLE_GL -DSHELL_ENABLE_METAL -DSK_GL -DSK_METAL -DSK_SUPPORT_GPU=1 -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_CODEC_DECODES_PNG -DSK_ENCODE_PNG -DSK_CODEC_DECODES_WEBP -DSK_ENCODE_WEBP -DSK_HAS_WUFFS_LIBRARY -DSK_ENABLE_DUMP_GPU -DSK_DISABLE_AAA...
> does this also need to cherry-pick #34508? Or at least the `#include "unicode/uchar.h"`
I didn't see ` error: Simulator not implemented` error, what command are you running? I tried: ``` $ ./flutter/tools/gn --no-goma --unoptimized --ios --simulator && ninja -C out/ios_debug_sim_unopt ios_test_flutter ``` Not...
@cyanglaz and I are actively debugging this right now, can we hold on the release hotfix until this is complete?
> When I cherry-picked in #34508 to see if `--icu-data-file-path=Frameworks/Flutter.framework/icudtl.dat` in the test scheme was needed but those failed as well: I think I hadn't built the engine properly on...
> However I don't have permission to push to your fork, @cyanglaz, can you try that? Created https://github.com/flutter/engine/pull/36807 to try the tests there.
The tests pass on https://github.com/flutter/engine/pull/36807 which means it should also pass on this one https://ci.chromium.org/p/flutter/builders/try/Mac%20Unopt/19879 since they are now the same.