plugins icon indicating copy to clipboard operation
plugins copied to clipboard

[in_app_purchase_storekit] Add identifier, type fields to SKProductDiscountWrapper

Open fengyuxx opened this issue 2 years ago • 9 comments

SKProductDiscount added "identifier", "type" two fields in iOS12.2, but the plugin is missing. In some discount purchase scenarios, we need these fields.

Fixes flutter/flutter#100602

Pre-launch Checklist

  • [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [x] I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • [x] I signed the [CLA].
  • [x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • [x] I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is [test-exempt].
  • [x] All existing and new tests are passing.

fengyuxx avatar Mar 23 '22 07:03 fengyuxx

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Mar 23 '22 07:03 flutter-dashboard[bot]

Thanks for the submission! @mvanbeusekom could you do the initial review here?

stuartmorgan avatar Mar 24 '22 20:03 stuartmorgan

Looks like this also needs a rebase onto the in_app_purchase_storekit changes on top of tree.

jmagman avatar Apr 11 '22 21:04 jmagman

@fengyuxx friendly bump, @cyanglaz had some requested changes on this PR. @mvanbeusekom were your requested changes addressed?

jmagman avatar May 23 '22 21:05 jmagman

@cyanglaz Looks like this is ready for re-review.

stuartmorgan avatar Jun 07 '22 17:06 stuartmorgan

@fengyuxx Looks like there are still conflicts. Do you mind merging/rebasing upstream and resolve the conflicts?

cyanglaz avatar Jun 29 '22 21:06 cyanglaz

@fengyuxx This is ready to merge, would you mind fixing up the version and CHANGELOG conflict?

jmagman avatar Jul 13 '22 20:07 jmagman

@cyanglaz Do you want to fork this PR into a new PR that we can land, since we're unable to fix the conflicts due to the permission restrictions on this branch?

stuartmorgan avatar Aug 04 '22 20:08 stuartmorgan

Forked at https://github.com/flutter/plugins/pull/6205

cyanglaz avatar Aug 04 '22 20:08 cyanglaz

Closing as obsolete; https://github.com/flutter/plugins/pull/6205 landed.

stuartmorgan avatar Aug 30 '22 15:08 stuartmorgan