plugins icon indicating copy to clipboard operation
plugins copied to clipboard

[in_app_purchase_storekit] Add identifier, type fields to SKProductDiscountWrapper

Open cyanglaz opened this issue 2 years ago • 0 comments

SKProductDiscount added "identifier", "type" two fields in iOS12.2, but the plugin is missing. In some discount purchase scenarios, we need these fields.

Fixes flutter/flutter#100602

This PR is a fork of https://github.com/flutter/plugins/pull/5102 On top of the original PR, the version is updated to 0.3.2 instead of 0.3.1.

See https://github.com/flutter/plugins/pull/5102#issuecomment-1205738246 for why the original PR is forked.

cc @fengyuxx

Pre-launch Checklist

  • [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [x] I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • [x] I signed the [CLA].
  • [x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • [x] I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is [test-exempt].
  • [x] All existing and new tests are passing.

cyanglaz avatar Aug 04 '22 20:08 cyanglaz

@cyanglaz points out this was already reviewed in https://github.com/flutter/plugins/pull/5102, this LGTM.

jmagman avatar Aug 10 '22 21:08 jmagman