Jesse Duffield

Results 532 comments of Jesse Duffield

@nitinmewar if you take a look at entry_point.go you'll see that you've inadvertently duplicated quite a bit of that code in your file changes so you'll need to fix that...

@nitinmewar if you click on the file changes tab and view the code that this PR adds, you'll see that it includes a bunch of code that you didn't actually...

Hey @nitinmewar do you intend to get back to this PR in the near future?

Up to you: feel free to close this and make a new PR

The solution here is that we should make those in-menu keybindings configurable too, would you agree?

I think we've got a data race on the `csiParam` field of our `escapeInterpreter` which surprises me because there's a mutex behind that on the view itself. Will need to...

@c02y I came across that same error myself recently and fixed it. Could you see if the issue is resolved on master?

Sweet. Though that's a different error to what's in the OP of this issue

FWIW all the action for this lives in `pkg/gui/services/custom_commands/handler_creator.go` specifically HandlerCreator's call method. Should be fairly easy to get to the bottom of