Jesse Duffield

Results 532 comments of Jesse Duffield

I have no intentions on fixing this anytime soon, but I will happily review a PR. Would you be up to the task?

Haven't had enough time to digest the questions you've posed @stefanhaller : but I wonder if we could run some cheap command to list the files of the commit, see...

When you hit enter on a file, we switch from showing whatever the `git show` command gave lazygit, to showing a diff that we colour ourselves. The reason for this...

I'm pretty sure `pkg/gui/files_panel.go:60` and `pkg/commands/files.go:161` are the places you want. Let me know if I'm wrong about that!

hmm interesting. This could be an issue with how the pty package runs on your os. If you look in the vendor directory there are a few different implementations: ![image](https://user-images.githubusercontent.com/8456633/112069701-65a18d00-8bc0-11eb-9f04-7332f1a24823.png)...

It's not official

Sorry for the late reply on this one. My understanding was that gpg signing always required a password. Is this not the case? If so, we can add a config...

It sounds like the best approach here is to introduce a config option to override the default behaviour of switching to a subprocess if GPG signing is enabled. In that...

just realised we actually already have a config key for this: `git.overrideGpg`

I too wonder why this flag is not passed by git by default. I've asked the following in the git [discord](https://discord.com/channels/1042895022950994071/1043101606549401661/1304719803381977088) (which I'm glad exists because I am not in...