lazygit added git version with version flag

added git version support for version flag

Aug 09 '22 11:08 nitinmewar

what should I do now?

Aug 11 '22 12:08 nitinmewar

Be patient and wait for Jesse's review :)

Aug 11 '22 12:08 mark2185

Code looks good @nitinmewar , you'll just need to fix those conflicts.

Aug 15 '22 10:08 jesseduffield

resolved 2 conflicts.

Aug 15 '22 11:08 nitinmewar

should I just wait now?

Aug 18 '22 12:08 nitinmewar

@nitinmewar if you take a look at entry_point.go you'll see that you've inadvertently duplicated quite a bit of that code in your file changes so you'll need to fix that up

Aug 18 '22 12:08 jesseduffield

sorry I couldn't find where is the problem. can you please describe?

Aug 18 '22 12:08 nitinmewar

@nitinmewar if you click on the file changes tab and view the code that this PR adds, you'll see that it includes a bunch of code that you didn't actually intend to add. That code lives in entry_point.go. I would start from scratch and try to apply the intended change to entry_point.go instead of main.go

Aug 18 '22 22:08 jesseduffield

okay!!

Aug 18 '22 23:08 nitinmewar

Hey @nitinmewar do you intend to get back to this PR in the near future?

Nov 12 '22 08:11 jesseduffield

@jesseduffield should I close this pr and make a new pr for this issue. this pr is messed up. I am sorry for this. should I proceed?

Nov 12 '22 09:11 nitinmewar

Up to you: feel free to close this and make a new PR

Nov 12 '22 09:11 jesseduffield

@jesseduffield so now I have to make changes in entry_point.go?

Nov 12 '22 10:11 nitinmewar

@jesseduffield I have raised a new pr. please review it at. #2265

Nov 12 '22 10:11 nitinmewar