Jesse Duffield
Jesse Duffield
It should be fairly easy to set up, though admittedly after a few minutes reading the [docs](https://difftastic.wilfred.me.uk/git.html) I haven't been able to get it working. Not sure if we need...
Lazygit invokes git as a subprocess, and for the pager we use the GIT_PAGER env var e.g. `GIT_PAGER=difft`. So perhaps we could conditionally use `GIT_EXTERNAL_DIFF` instead of `GIT_PAGER`?
when I run `GIT_EXTERNAL_DIFF=difft git diff` in the CLI that works fine, but when I do `cmd.Env = append(cmd.Env, "GIT_EXTERNAL_DIFF=difft")` in `pkg/gui/pty.go:53` (`newPtyTask` function) it appears like the regular diff...
@aruediger we can make that --no-ext-diff thing configurable. Would that suffice? Happy to accept a PR for this
I haven't though through how we would implement this feature but I'm certainly on board for it. Happy to accept a PR
This is a good idea for a feature. Rather than populate the commits panel it makes more sense to populate the 'sub-commits' panel which you reach when you press enter...
Wow! Didn't expect that you'd pick up on all the current patterns. Code looks pretty good so far, I'll try to find time on the weekend to give it a...
@kadaan thanks for waiting, I'm gonna give this another review this weekend
Some more things I noted from locally testing: * interestingly, a worktree named 'foo' will appear in `git status --short` as 'foo/'. Lazygit expects all status changes to be files,...
All good @kadaan, no rush from my end :)