jesseduffield
ignoreFile keyblinding doesn't work
Describe the bug
A clear and concise description of what the bug is.
ignoreFile keyblinding doesn't work.
After upgrading lazygit to 0.35, i found that ignoreFile keyblinding is conflicted with nextBlock-alt.
To Reproduce Steps to reproduce the behavior:
- map ignoreFile keyblinding to
u - map nextBlock-alt keyblinding to
i - scroll to files block
- press
i - then it start to ignore files
Expected behavior A clear and concise description of what you expected to happen. ignoreFile keyblinding works
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
- OS: Archlinux
- Lazygit Version : v0.35
- keyboardLayout: colemak
Additional context Add any other context about the problem here. here is my config
gui:
showIcons: true
keybinding:
universal:
prevItem-alt: 'e'
nextItem-alt: 'n'
prevBlock-alt: 'h'
nextBlock-alt: 'i'
nextMatch: '='
prevMatch: '-'
new: 'k'
edit: 'o'
openFile: 'O'
scrollUpMain-alt1: 'U'
scrollDownMain-alt1: 'E'
scrollUpMain-alt2: '<c-u>'
scrollDownMain-alt2: '<c-e>'
undo: 'l'
redo: '<c-r>'
diffingMenu: 'M'
filteringMenu: '<c-f>'
files:
ignoreFile: 'u'
commits:
moveDownCommit: '<c-e>'
moveUpCommit: '<c-u>'
branches:
viewGitFlowOptions: 'I'
setUpstream: 'U'
The solution here is that we should make those in-menu keybindings configurable too, would you agree?
That will be nice, thanks a lot
The solution here is that we should make those in-menu keybindings configurable too, would you agree?
Upon re-reading the OP I'm actually confused as to what the problem is: is the issue that when you're in the files panel, pressing 'i' brings up the ignore menu even though you've mapped the ignore key to 'u'?
Not OP, but that is what happens. The rebind is ignored. Other rebinds in the files module work with no problems I tried u with the tree toggle and there is no problem but rebinding ignoreFile to anything does nothing.
huh interesting. That sounds like a much easier fix then. Fixed in https://github.com/jesseduffield/lazygit/pull/2303