Jesse Duffield
Jesse Duffield
Sounds good @Liberatys :)
@mark2185 I'm inclined to wrap it in a menu, however, that won't solve this issue which is related to the number of keypresses, because the keypress count remains the same.
I guess if you want to reword a heap of commits in quick succession you'd use a rebase with each line having an 'edit' action (that's just off the top...
Sorry for the late reply. I wonder if other people would want this behaviour. I like lazygit opening based on the root of the repo as opposed to whatever folder...
Nice work @ryand67 . Before I look into the code more closely, I'm wondering what the typical use case would be here. E.g. resetting to origin/master perhaps. If we know...
Tagging @mark2185 because you raised the issue :)
There's likely some overlap with my above review and what @mark2185 has already stated: I had that review in a pending state but hadn't gotten around to submitting it. I...
@mark2185 you've convinced me. Just to be clear on the pros/cons in my head: benefits of the two-phased approach: * fewer items in any given menu, so easier to parse...
Did you have any opinions on the UX side of this @ryand67 ?
@ryand67 hope you're feeling better now :) Let's go ahead with the one-phase approach described in https://github.com/jesseduffield/lazygit/pull/2047#issuecomment-1193788532