Josh Matthews

Results 1175 comments of Josh Matthews

Once the fixes in #40353 and #40323 are merged I'm going to make a PR to enable this feature by default.

I think the issue here is that this: https://github.com/servo/servo/blob/41eb145093ef4472506334e93594d22f5dfe12f0/components/script/dom/document.rs#L3269-L3270 Does not actually prevent any queued tasks that are intending to dispatch load events, like https://github.com/servo/servo/blob/41eb145093ef4472506334e93594d22f5dfe12f0/components/script/dom/document.rs#L2943 . This makes the assertion...

Given nobody can reproduce this yet, let's go ahead and close it.

I suggest using the objc2-core-graphics crate instead, which meets your needs: https://docs.rs/objc2-core-graphics/latest/objc2_core_graphics/struct.CGMouseButton.html

We still.occasionally accept pull requests, but we strongly encourage migrating to https://github.com/madsmtm/objc2/tree/main/framework-crates/objc2-core-graphics instead.

Need to check if the PR approval status is available in the pull request API object.

Using https://github.com/servo/servo/pull/39401 as a PR that matches, https://api.github.com/repos/servo/servo/pulls/39401 doesn't have any fields about whether any approved reviews have been posted. We'll need to fetch https://api.github.com/repos/servo/servo/pulls/39401/reviews and process each entry in...

The problem is that you have a linear chain of dependencies that lead to slow compilation time when making a change earlier in the chain. This pattern is a way...

The pull_request object includes these fields: ``` "commits": 2, "additions": 72, "deletions": 10, "changed_files": 2 ```