Josh Matthews
Josh Matthews
Hmm, this is actually an interesting point to consider. We don't _necessarily_ want to use whatever version number exists in the embedding; that number should probably be provided to the...
I would probably add a servoshell identifer and version number to the user agent like the example in https://github.com/servo/servo/issues/33520#issuecomment-2816853811.
To encourage pages doing user agent sniffing to treat Servo like Firefox.
https://github.com/servo/servo/blob/e531770db6da91db3d197a877904670c01958087/components/script/dom/bindings/constructor.rs#L89-L95
I think we can trigger the same panic by adding an iframe to a page, storing iframe.contentWindow, removing the iframe, and using contentWindow.localStorage. I think https://github.com/servo/servo/blob/974e22773668cd95e78d19edd4190c04bb6616cb/components/script/dom/window.rs#L559 really should not hide...
The other question I have here is whether a timer running in a global that has a discarded browsing context is supposed to run or not.
This is actually much more subtle than I thought. The only time that Window's `window_proxy` member is set to None is when a pipeline is exiting, and that's supposed to...
Previously pointed out in #24459 and further discussion in #28298.
```html let i = document.createElement('iframe'); document.body.appendChild(i); let c = i.contentWindow; i.remove(); setTimeout(() => c.localStorage['boom'], 0); ``` Consistent panic.
This may be related to how servo handles `touch-action: none`, or it may be related to the way we dispatch wheel events.