Josh Matthews

Results 1165 comments of Josh Matthews

I'm not sure I understand the cause and effect yet—if a video element is not attached to the window and is GCed, how are there observable effects in the tests?...

> but the question how to remove these media elements later (identify that the global scope is the latest owner). I think that adding a bind_to_tree implementation that transfers ownership...

Ah, the message is actually `@servo-highfive assign me`.

It's very interesting that three separate cookiestore tests reported new results.

There's something very strange going on here. I've been stepping through a test that times out with these changes, and https://github.com/servo/servo/blob/main/components/script/dom/cookiestore.rs#L63 only appears to be called once despite multiple send...

Specifically, [this subtest](https://github.com/servo/servo/blob/a926260fb07340710fe786685c7f2d89f0bf1b77/tests/wpt/tests/cookiestore/cookieStore_set_limit.https.any.js#L42-L46) times out waiting for the get operation to resolve: https://github.com/servo/servo/blob/a926260fb07340710fe786685c7f2d89f0bf1b77/tests/wpt/tests/cookiestore/cookieStore_set_limit.https.any.js#L62

Oh wait, that's probably related to `0:02.19 pid:87629 [2025-12-19T20:15:12Z WARN script::dom::cookiestore] Error receiving a CookieStore message: Custom("EmptyName")`

Ok, so here's one behaviour change that leads to the test results changing: by switching from IpcSender to GenericSender for the ResourceThreads, in single process mode we now transfer ownership...

I propose: ```diff diff --git a/components/net/resource_thread.rs b/components/net/resource_thread.rs index c49f308772d..71904214f6f 100644 --- a/components/net/resource_thread.rs +++ b/components/net/resource_thread.rs @@ -258,7 +258,7 @@ impl ResourceChannelManager { // Handles case where profiler thread shuts down before...

So, this explains: * TIMEOUT->OK (the IPC messages containing invalid cookies were previously dropped by the resource thread) * TIMEOUT->CRASH (same, except now the invalid cookie gets set in an...