Josh Matthews

"getting a promise to wait for all of the actions" links to https://webidl.spec.whatwg.org/#waiting-for-all-promise, which makes it clear that order only matters for fulfillment, not rejection. This test case is about...

Yeah, they're queued in that order, but I don't find it easy to determine that the first one should definitely reject the promise before the second one. I think I...

https://github.com/servo/servo/blob/ae62ab7fa7a2a4b903879b2673d7bc7a586a3850/components/constellation/constellation.rs#L5444-L5448

I think we want get_join_session_history to return an Option instead of panicking if the requested webview no longer exists. I first want to confirm whether that's the case here, or...

Minimized testcase: ```html ``` Firefox: Servo:

https://github.com/servo/servo/blob/3b205ad8f278c54113348eea1d5eb24d500e5008/components/layout/replaced.rs#L149 is the code that obtains image width/height values and determines the aspect ratio, via https://github.com/servo/servo/blob/3b205ad8f278c54113348eea1d5eb24d500e5008/components/layout/replaced.rs#L89 and https://github.com/servo/servo/blob/3b205ad8f278c54113348eea1d5eb24d500e5008/components/layout/replaced.rs#L72.

https://github.com/servo/servo/blob/ae62ab7fa7a2a4b903879b2673d7bc7a586a3850/components/script/dom/html/htmloptionscollection.rs#L224 I believe we are supposed to throw an exception at this step: https://github.com/servo/servo/blob/ae62ab7fa7a2a4b903879b2673d7bc7a586a3850/components/script/dom/html/htmloptionscollection.rs#L203 However, is_ancestor_of explicitly treats child==self as true, which doesn't seem quite correct to me: https://github.com/servo/servo/blob/ae62ab7fa7a2a4b903879b2673d7bc7a586a3850/components/script/dom/node.rs#L917

In particular, is_inclusive_ancestor includes a child==self check before calling is_ancestor_of, so I think is_ancestor_of needs to change: https://github.com/servo/servo/blob/ae62ab7fa7a2a4b903879b2673d7bc7a586a3850/components/script/dom/node.rs#L913

The xpath implementation is already decoupled from Servo's DOM: https://github.com/servo/servo/tree/main/components/xpath It has a trait abstracting away the implementation details: https://github.com/servo/servo/blob/9a1d86cc88af44dda6a5bd65c17db5cd40ff6428/components/xpath/src/lib.rs#L28

Yep! Pull requests accepted.