highfive icon indicating copy to clipboard operation
highfive copied to clipboard

Consider adding sizing labels for pull requests

Open simonwuelker opened this issue 6 months ago • 4 comments

https://github.com/mdn/browser-compat-data has different labels that are automatically applied to pull requests based on their size. For example, a PR that updates 0-6 LoC will get the size:xs label, whereas one that updates 25-100 LoC will get size:m.

These labels serve two purposes:

  • They can hint to the author that the PR should be split up into smaller changes (size:xl)
  • They (roughly) indicate to reviewers how much effort it is to review the PR, without first having to click on it

I think these labels are useful and it would be nice to have the highfive bot apply them to servo PRs. Might be a bit noisy though, we would have to see.

simonwuelker avatar Sep 08 '25 20:09 simonwuelker

Definitely a neat idea!

jdm avatar Sep 08 '25 20:09 jdm

The pull_request object includes these fields:

    "commits": 2,
    "additions": 72,
    "deletions": 10,
    "changed_files": 2

jdm avatar Sep 09 '25 00:09 jdm

Can we ignore WPT changes for this? E.g. would be a shame if a tiny fix with loads of WPT tests fixed would be marked as large, which discourages reviews.

TimvdLippe avatar Sep 13 '25 16:09 TimvdLippe

Good point!

jdm avatar Sep 13 '25 17:09 jdm