Josh Matthews

Results 1165 comments of Josh Matthews

Minimized testcase: ```html const e = document.querySelector('#e'); e.onwheel = (ev) => ev.preventDefault(); ``` In Firefox attempting to scroll over the red box will do nothing. In Servo the page will...

I'm pretty sure the problem is this: https://github.com/servo/servo/blob/b7263e7fda4e10ae9d86a501c22d74f45138c60b/components/compositing/webview_renderer.rs#L393-L405 We dispatch the input event, but we immediately push a pending scroll event (in https://github.com/servo/servo/blob/b7263e7fda4e10ae9d86a501c22d74f45138c60b/components/compositing/webview_renderer.rs#L684-L696) without waiting to see if content called...

The JS error is triggered by this minimized sample: ```html console.log(getComputedStyle(document.querySelector('div')).transform) ``` In Firefox this prints `matrix(1, 0, 0, 1, 0, 0)`, in Servo it prints `scale(1)`.

This happens in Firefox because of this code: https://searchfox.org/firefox-main/rev/7496c8515212669451d7e775a00c2be07da38ca5/layout/style/nsComputedDOMStyle.cpp#2293-2296

Specification: https://drafts.csswg.org/css-transforms-2/#serialization-of-the-computed-value We're missing this logic.

We'll want to add this logic inside of https://github.com/servo/servo/blob/b7263e7fda4e10ae9d86a501c22d74f45138c60b/components/layout/query.rs#L206.

I verified that the original page interaction works as expected when the expected serialization is present.

Nope! I just replaced the getComputedStyle call in the page with a constant string with the expected value.

> The code itself looks good. Very excited for this! > > Side notes: I've been verifying the execution path, and found some redundancy for channel communication which has been...

I suspect that this needs to be dealt with inside of winit rather than the Servo engine code. All we get is a number, which we pass on to the...