node
node copied to clipboard
nodejs
test: use platform time
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.33%. Comparing base (
eb7e18f) to head (68fc01d). Report is 308 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #54591 +/- ##
==========================================
- Coverage 87.33% 87.33% -0.01%
==========================================
Files 649 649
Lines 182571 182562 -9
Branches 35025 35025
==========================================
- Hits 159450 159442 -8
+ Misses 16400 16393 -7
- Partials 6721 6727 +6
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
AssertionError [ERR_ASSERTION]: ifError got unwanted exception: ENOSPC: no space left on device, write
😞 should I cc build team?
parallel/test-async-context-frame happened to be quite flaky - https://github.com/nodejs/reliability/blob/main/reports/2024-09-05.md#jstest-failure
PR is currently blocked from landing due to unreliable CI. Looks like the OSX runner is jammed up.
Artifacts were being cleared up due to space issue on jenkins, restart again 😞
Commit Queue failed
- Loading data for nodejs/node/pull/54591 ✔ Done loading data for nodejs/node/pull/54591 ----------------------------------- PR info ------------------------------------ Title test: use platform time (#54591) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch jakecastelli:fix-54499-use-platform-timeout -> nodejs:main Labels test, needs-ci, commit-queue-rebase Commits 2 - test: use platform time - test: add support for riscv64 Committers 1 - jakecastelli <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54591 Refs: https://github.com/nodejs/node/issues/54499 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54591 Refs: https://github.com/nodejs/node/issues/54499 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 27 Aug 2024 15:47:09 GMT ✔ Approvals: 4 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54591#pullrequestreview-2266146066 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/54591#pullrequestreview-2266335377 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54591#pullrequestreview-2274122760 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/54591#pullrequestreview-2288561280 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-09-11T10:11:33Z: https://ci.nodejs.org/job/node-test-pull-request/62308/ - Querying data for job/node-test-pull-request/62308/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10811599903