Jake Bailey comments

Results 1475 comments of


                                            Jake Bailey

[node] Fix `http.createServer` signature

> Yes, and what's that got to do with this PR?! > > I haven't touched that module at all! 😭 A change to the node types can break deps...

[node] Fix `http.createServer` signature

Sent https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70297

[node] Fix `http.createServer` signature

It needs to be reviewed, yes, or time out and move into needing a maintainer to look at it manually. I would suggest merging from `master` to pull in the...

[node] Fix `http.createServer` signature

That is a new 5.7 break we are going to fix on master (sorry...)

[@types/dom-webcodecs] add missing "dequeue" event to (Video|Audio)(En/De)coder

It seems like the generator hasn't been updated in three years, and the package here hasn't been touched by anyone but maintainers (for fixes / formatting). I know some of...

fix(nodemailer): update SentMessageInfo interface to include more specific properties

You didn't change anything in response to my feedback; I'm not sure why you've re-requested review.

Update tests and definitions to support generic typed arrays

Seems like the remaining failure is just an ExpectType recently merged into DT.

[nw.js] Update typings to v0.92.0

The docs don't provide any info on the types of the function or how to use it; is there some source which can give this info for me to verify?

refactor(node): use ESM instead of CJS in JSDoc comments

Aren't these docs generated by Node's docs?

refactor(node): use ESM instead of CJS in JSDoc comments

> > Aren't these docs generated by Node's docs? > > It’s currently impossible to do it. But we would definitely love to. Then what's the deal with https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/70298?