Jake Bailey
Jake Bailey
Asked @andrewbranch and this the above is working as intended; this code would emit CJS (it sets module=commonjs) and therefore would simply not work when used with Vite anyway.
chai is known broken in https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/attw.json#L182, you'd need to add `chai/v4` now that you're introducing it.
@tpluscode Did you verify that these packages still work with the chai v4 types? Or are all of these packages implicitly depending on v5 now? This is a very critical...
chai v5 going ESM-only is very much holding people back to v4, so trying to make that keep working would be nice. Unfortunately, there isn't yet a great way to...
I'm really not sure what to do here at this point. It's just a fact that for TypeScript users to use a library, that library needs `.d.ts` files. They _have...
> it wouldn't exist if I could simply control the types over the packages I maintain, the fact that package maintainers don't have permissions to their own types is a...
Removing the types and breaking all TS users is a totally different scenario to just updating the types so that they're correct. Adding/removing packages from DT is something that has...
The options here are: - You put `.d.ts` files (of any quality, I don't care!) into your packages making them typed, we merge this PR after those are published so...
I'll re-up this one more time; I'm really wanting to get this handled, but we really need to know which of the previously noted options will work best.
> IMO this is pretty much a failure of the CI on that PR, maintainers was that intentional? This is a known hole in CI; the package isn't shimmed on...