Jake Bailey
Jake Bailey
I'm not 100% clear why `(Anonymous class)` is more consistent. The `(Missing)` change seems correct because it improves a baseline, but otherwise I'm not sure.
Old PR, but it would be worth updating this PR I think, at least into a form that reduces baseline diffs. I'd rather that be the outcome.
Er, well sort of, but it's not reducing diffs, it's still changing the behavior.
I'd leave the tests here; it's fine for tests to be "duplicated" between the two temporarily. The names will not conflict.
@typescript-bot test it
For reference, now that `checker.getAwaitedType` is officially documented in TS 5.6 (present since 4.0), I wanted to simplify the rule to just use this: ```ts function isPromiseLike(checker: ts.TypeChecker, type: ts.Type):...
It'd be appreciated if any new repros were filed as new issues; it's not easy to track problems on closed issues.
When I try your repro, the resolution fails and jumping to the resolved module brings up this file: ``` /** * @deprecated The CJS build of Vite's Node API is...
The only reason this would have worked in the old compiler is that your code is using the old node10 resolution mode (not recommended), which mistakenly resolves vite to the...
A fresh issue would be helpful, because the initial repro here was for bundler mode, which was broken for a different reason. (That's why I was asking for one 😄)