Jake Bailey
Jake Bailey
Hm, this package has 1.3 million downloads, though. That's 1000 extra files to ship to everyone; that's not so good. That and 1000 extra files to auto-import ☹️ You mentioned...
I absolutely agree that this is a technically correct change. It would be interesting to pull up a project which uses this library just to verify it does the right...
Bug in the lint rule, nice. EDIT: I can't fix it without https://github.com/golang/go/issues/73278 or a bunch of finagling to fix up the CFG, so I'll just rename the var to...
Realized that none of this even needs to be locked; we can just put the info onto the tasks, which we collect later anyway.
> `const a = require('x').a` is no longer supported. This surprises me; how are we choosing to drop this? > A secondary question is: should module, exports and require error...
Is there anything left in this PR? It's hard to view and the thread is long so I'm not sure where we are at; I tried to skim the code...
This just declares some global interfaces and allows them to be passed, but without those interfaces existing globally, they'll allow anything to be assigned to them (AFAIK). Are these typed...
This is to be expected; our lib files come from a "random revision from last fall": https://github.com/microsoft/typescript-go/tree/main/_submodules We're intending on bumping this, doing so will just mean we need to...
Mainly, bumping the submodule brings in all of the new tests from all of the changes since then, all of the message changes, new compiler options, etc.
Fixed by #1019; should be published within an hour.