Jake Bailey
Jake Bailey
@typescript-bot perf test startup-only [email protected],[email protected]
As a note to self, if/when we switch to ESM when `require(ESM)` is stable, to ensure `require("node_modules/typescript/lib/tsc.js")` still works (is synchronous), we'd need to write this: ```ts const { createRequire,...
@typescript-bot perf test this faster [email protected],[email protected]
@vadzim Compare: https://www.typescriptlang.org/play/?strictNullChecks=false#code/PTAEAEGcBcCcEsDG0ByBXANhgwgCwKaIDWkAXKAGYCGGk+AsAFAgQB2A9gJIC2ADhknjQAgqwCe5OGgaMmAE0IYqsfKABuy0L3IAFWO27w6AHlZpuAI3ywAfAG4midqxhaATKAC8WgHSIq0Ii4ABTBAJReNqBmWGEOzGCgSQB6APxAA To: https://www.typescriptlang.org/play/?strictNullChecks=false&ts=5.8.0-dev.20241119#code/PTAEAEGcBcCcEsDG0ByBXANhgwgCwKaIDWkAXKAGYCGGk+AsAFAgQB2A9gJIC2ADhknjQAgqwCe5OGgaMmAE0IYqsfKABuy0L3IAFWO27w6AHlZpuAI3ywAfAG4midqxhaATKAC8WgHSIq0Ii4ABTBAJReNqBmWGEOzGCgSQB6APxAA Both are any, and this PR issues the error in the latter.
Very unlikely; consider using https://www.npmjs.com/package/every-ts to bisect the change.
Please file a new issue, then. Thanks.
Tested locally with main and it merges and passes cleanly.
Yeah, that would probably be a regression. Should definitely have a test for it...
This was merged skipping checks; not sure that was intended. @hyzyla I would recommend sending PRs from branches on your fork rather than main; that's why we couldn't modify it.
Can you try the build on https://github.com/microsoft/TypeScript/pull/59709#issuecomment-2305582124 to see if that fixes your issues?