Jake Bailey
Jake Bailey
@copilot This is just a band-aid fix. The real problem is that we have this chain of AST nodes: ``` KindStringKeyword KindParameter KindMethodDeclaration KindSourceFile ``` We should not have a...
Well, that is certainly wrong. Do we even allow overloads on object literal methods in TypeScript? Is this just something we must ban in JS? @sandersn
@copilot This fix is too broad. We need to instead change the reparser to ban `@overload` in any context where an overload would not be legal in TS, which should...
@copilot This should not be a silent error. We have a mechanism to issue JSDoc errors in parsing; use that.
Where are you using this API such that it matters for you? It's not guaranteed to work and I'm not sure we are expecting people to use it truly concurrently...
I'm not sure I understand; if this were panicking wouldn't everything be broken right now?
Ah, this is https://github.com/oxc-project/tsgolint/issues/318. I didn't realize you meant a knock-on effect from a later regex call.
The latest commit is not exactly what I mean; I wasn't trying to say to continue to change the escaping, but rather fix `getWildcardDirectories` to not use Go's regexp package,...
Why does Strada not need the escaping change, though?
Honestly, this PR is probably fine. It would be good to make a test that would have crashed before. But, I would like to have this change upstreamed.