Iván Valdés Castillo

Results 428 comments of Iván Valdés Castillo

Hi @jmhbnz, after reviewing today's triage meeting notes, I see this issue was discussed. As agreed in the meeting (the recording is not on YouTube yet), #15060 should be closed...

/test pull-kubernetes-verify

The initial implementation in #750 is benchmarking only the default write and read modes (write=rnd, read=seq). @ahrtr, should we expand the benchmarks to other combinations?

@ahrtr, I deleted the `-read-mode` flag, as the only option available was `seq`. Providing any other value halted the execution. However, changing from built-in Go flags to Cobra flags isn't...

Hey @moficodes, as discussed during the triage meeting, there is a Markdown lint rule regarding this. Please refer to: https://github.com/markdownlint/markdownlint/blob/main/docs/RULES.md#md014---dollar-signs-used-before-commands-without-showing-output Regarding linting, refer to: https://github.com/etcd-io/website/pull/774#discussion_r1498552258

I agree, but if the code block also contains sample output, what's the value of copying it? I think we need someone else (thinking of @jmhbnz after he returns from...

Thanks for addressing my comments, @LLiuJJ. I'm waiting for the conclusion in #17464 to see how to proceed with this PR.