Iván Valdés Castillo
Iván Valdés Castillo
Hi @redwrasse, thanks for your pull request. I did a `grep 'err =='` in your branch, and excluding `err == nil`, I still see some instances of comparisons using `==`....
@redwrasse, sorry for the back and forth sweat_smile: I should have probably given you the list of files since the beginning. So here are some others that I see after...
@redwrasse, what do you think if we scope it to the files you have already edited in this pull request? In that case, here's the list of missing ones (basically...
Thanks for addressing, @redwrasse. Can you squash your commits, please? Thanks again.
Link to #18576. Do we have enough approvals to merge this?
> No concerns. > > Replacing `err ==` with `errors.Is` seems correct and safe enough that we can do it in bolk like this. Would be interesting if there is...
We covered this in the fortnightly etcd triage meeting. In #509, the decision was to implement a logger interface compatible with `go.uber.org/zap`. I'm torn because implementing a bridge/wrapper struct for...
Hi, @PaluMacil, thanks for your input. When the team decided what logging interface to use, `slog` was still experimental (refer to #509). I don't object to adopting or doing a...
Closing as complete. https://github.com/etcd-io/etcd/pull/18460 updated the CHANGELOG.
Discussed during the fortnightly triage meeting. I'll review the PR.