etcd icon indicating copy to clipboard operation
etcd copied to clipboard

Fix bug with issues [17464] fix with zap logger redirection

Open LLiuJJ opened this issue 1 year ago • 9 comments

etcdctl: fix etcdctl zap logger redirection bug

This bug was report with issues https://github.com/etcd-io/etcd/issues/17464

Here is my test log

snaphot_cmd_test

Signed-off-by: Colin [email protected]

LLiuJJ avatar Feb 29 '24 18:02 LLiuJJ

Hi @LLiuJJ. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 29 '24 18:02 k8s-ci-robot

/ok-to-test

LLiuJJ avatar Mar 06 '24 13:03 LLiuJJ

@ivanvc

siyuanfoundation avatar Apr 25 '24 18:04 siyuanfoundation

/cc @ivanvc

ivanvc avatar Apr 25 '24 18:04 ivanvc

/retest

LLiuJJ avatar Apr 28 '24 15:04 LLiuJJ

Thanks for addressing my comments, @LLiuJJ. I'm waiting for the conclusion in #17464 to see how to proceed with this PR.

ivanvc avatar May 06 '24 17:05 ivanvc

/retest

LLiuJJ avatar May 07 '24 15:05 LLiuJJ

/retest

LLiuJJ avatar May 07 '24 16:05 LLiuJJ

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 16 '24 14:10 k8s-ci-robot