Iván Valdés Castillo
Iván Valdés Castillo
@Scotchman0, it may be helpful if you can add the current output to compare to your suggestion. /assign @Scotchman0
I like the idea, but after seeing the implementation, I wonder if it would be better to add more columns rather than reusing/multi-purposing the current column. I defer to @ahrtr...
The first five performance jobs are running in the K8s test EKS clusters. We still need to add the last three jobs.
This makes sense, @serathius; thanks for your input. @jmhbnz, should we regroup and formalize a proposal?
Hi @flawedmatrix, I suggest squashing the commits in preparation for merging this PR.
Please feel free to revert it. I wasn't aware that it'd break other components. :v:
Hi @thedtripp, it looks like your commit message is wrongly formatted (signed-off-by appears twice). I also suggest co-authoring with the author of the original PR #16902. /ok-to-test
Hi @jmhbnz, the original suggestion from https://github.com/etcd-io/etcd/pull/16902#pullrequestreview-1725849250 was to add an integration or e2e case for this functionality. But later in https://github.com/etcd-io/etcd/issues/16866#issuecomment-2104180883, you refer to it as basic testing. The...
Thanks, @thedtripp, this is looking good. I suggest squashing your commits into a single one in preparation for merging this PR.
> Is it ok to squash the commits with interactive rebase? Yes! That's how I usually do it :roll_eyes: :smile: