etcd
etcd copied to clipboard
etcd-io
Re-write rw-heatmaps tool in golang
What would you like to be added?
Sub task under #16467
We currently have https://github.com/etcd-io/etcd/tree/main/tools/rw-heatmaps as a helpful custom utility for qualifying etcd performance visually.
Unfortunately the current tooling is written in python which doesn't make sense for etcd as a golang project and introduces challenges keeping the tool maintained.
There was a historic stale attempt at this rewrite https://github.com/etcd-io/etcd/pull/15060 however this changed the existing tool functionality so was not a simple rewrite and did not get consensus to proceed.
@ivanvc has begun work on a newer rewrite that does not introduce any new features and would give us a clear pathway forward.
Why is this needed?
We need well maintained tooling to regularly qualify the performance of etcd.
@jmhbnz: GitHub didn't allow me to assign the following users: ivanvc.
Note that only etcd-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
In response to this:
/assign @ivanvc
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Leaving a comment so you can assign it to me, or perhaps prow will do it if I try?
Hi @jmhbnz, after reviewing today's triage meeting notes, I see this issue was discussed. As agreed in the meeting (the recording is not on YouTube yet), #15060 should be closed when I implement the line charts (hopefully soon). In my opinion, this issue can be closed now, but @ahrtr may also want to weigh in.
In my opinion, this issue can be closed now, but @ahrtr may also want to weigh in.
Closed.
OOPS, I misread the comment above, I closed the PR instead of this issue. I am good as long as eventually we can integrate the line chart. Please feel free to close this issue if you want.