Iván Valdés Castillo comments

Results 428 comments of


                                            Iván Valdés Castillo

etcdctl outputs regular log messages on /dev/stderr

#17510 solves the redirection issue for this specific command. However, after reviewing that PR, IMO solving this on a per-command basis doesn't sound clever. Do we want to redirect info...

etcdctl outputs regular log messages on /dev/stderr

Now, #17510 is aiming to address the issue for all of the `etcdctl` commands. I suggest reaching a conclusion on what we want to do here before we move forward...

[3.4] Linters fail locally, but pass on CI

/label area/testing

[3.4] Linters fail locally, but pass on CI

/assign @henrybear327

[3.4] Linters fail locally, but pass on CI

Please take a look at #17400 and #17401 as a reference.

[3.4] Linters fail locally, but pass on CI

Thanks for working on this, @thedtripp. Closing as completed.

build(deps): bump github.com/rivo/uniseg from 0.2.0 to 0.4.7

Should I take this one while working on this week's dependency updates?

build(deps): bump github.com/rivo/uniseg from 0.2.0 to 0.4.7

@ahrtr do we want to bump `github.com/rivo/uniseg` and `github.com/mattn/go-runewidth`? These are indirect as `github.com/cheggaaa/pb/v3` is already on its latest version v3.1.5.

build(deps): bump github.com/rivo/uniseg from 0.2.0 to 0.4.7

I was asking because I didn't see any CVEs addressed in their release notes either. I already bumped it but didn't push the commit. I'll add it to #17576.

Resolve: PRISMA-2023-0056

Hi, this dependency update was indeed released on 3.4.31/3.5.13. However, we never got the update to the CHANGELOG. I believe that's the only thing remaining to close this issue. @vivekpatani,...