Iván Valdés Castillo

Results 430 comments of Iván Valdés Castillo

> Im not sure about this test https://github.com/etcd-io/etcd/actions/runs/9534220896/job/26278395488?pr=18183 I think you need to run a `make fix` and commit the changes to the `go.mod`s, because you moved a file from...

Speaking of moving the file from `pkg/cobrautil` to `etcdctl/util`, why did you decide to do so? I'm not persuaded by this change, as if at some point we want to...

/retitle Add examples to `etcdctl snapshot` command's help

Hi @redwrasse, thanks for the pull request. Due to its size and ease of review, would you be able to help us break it into multiple smaller PRs? I suggest...

Link to https://github.com/etcd-io/etcd/issues/18576

@redwrasse, is it okay to assign you to our new parent issue for this? (https://github.com/etcd-io/etcd/issues/18576) If that's ok, you can comment `/assign` on that issue, and k8s-bot will assign it...

Hi, @joshjms. Please also take a look at my comment on the parent issue (https://github.com/etcd-io/etcd/issues/18707#issuecomment-2434174108). I believe the proposed breakdown it's a bit different from what this pull request has....

If you do so, you need to update the configuration file. Please review the CI failure.

Reference to Slack thread from @jberkus: https://kubernetes.slack.com/archives/C3HD8ARJ5/p1736815261935089