gofail icon indicating copy to clipboard operation
gofail copied to clipboard

chore(CI): add gci formatter

Open Elbehery opened this issue 6 months ago • 3 comments

This PR add gci import formatter to this repo.

See https://github.com/etcd-io/bbolt/pull/988#discussion_r2148704895

cc @ahrtr @ivanvc

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Elbehery avatar Jun 17 '25 12:06 Elbehery

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 17 '25 12:06 k8s-ci-robot

Thanks @ivanvc

So I had to bump golangci lint, so that I can add gci

you find details in this CI run

Elbehery avatar Jun 19 '25 07:06 Elbehery

If you do so, you need to update the configuration file. Please review the CI failure.

ivanvc avatar Jun 20 '25 14:06 ivanvc