Iván Valdés Castillo

Results 430 comments of Iván Valdés Castillo

I just reviewed PR #1015. I agree with @jberkus, this is a one-shot script, that doesn't update any of our markdown files. In that case, the script should belong in...

Hi, @webdawg. Unfortunately, the website doesn't have access to the compiled `etcd`. If we wanted to do so, we would need to do it through a GitHub action or something...

Hi @ianlancetaylor, Thanks for raising this issue. We aim to have the main branch working with the [latest Go version released](https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/dependency_management.md#golang-versions). When a new minor is released. We work to...

We discussed this issue and https://github.com/etcd-io/etcd/pull/18510 in our fortnightly etcd triage meeting. We'll keep this issue open and use it as an umbrella to track the adoption of `errors.Is`.

/retitle Use `errors.Is` for error equality checks

> @ianlancetaylor, I'm a culprit here, but it occurred to me- are there possible performance concerns with `errors.Is` to be considered against the benefits of robustness to error wrapping, that...

Once we finish addressing this, let's enable https://golangci-lint.run/usage/linters/#errorlint as part of this effort, as suggested by @mmorel-35.

Closing as all tasks are complete, and the `errorlint` linter is now enabled. Thanks for your work on this, @mmorel-35 and @redwrasse! :bow:

Hi @jcferretti, thanks for your contribution. Could you please sign your commit? So the developer certificate of origin (DCO) check passes, i.e: ``` git rebase HEAD~1 --signoff git push --force...

@ahrtr, @jmhbnz, @serathius, PTAL :)