Iván Valdés Castillo
Iván Valdés Castillo
As I was reviewing https://github.com/etcd-io/etcd/pull/20590, I noticed that we're using a `require.errorIs` with a `rpctypes` error. Note that this is not an `ErrGRPCxxxx` error. However, I updated the test case...
Sorry, @cruvie. I may have needed to be clearer. Internally testify's `ErrorIs` assertion uses `errors.Is`: https://github.com/stretchr/testify/blob/master/assert/assertions.go#L2172-L2178. I wrote an e2e test (using our test framework) to verify the behavior: https://gist.github.com/ivanvc/2a0fb878bd6b79e2964b6c06357107b1...
@cruvie, can you try `rpctypes.ErrUserEmpty`? I couldn't make it match with GRPC
> May I ask where exactly I should raise this issue? I think https://github.com/kubernetes/test-infra, the image that may have the issue is: https://github.com/kubernetes/test-infra/tree/master/images/kubekins-e2e-v2.
@henrybear327, if you have the time and know what to do, I'd say go for it. :)
@henrybear327, 1.23.1 was released today. Could you please update this PR to bump to the latest patch? Thanks.
Yes, if you want, please refer to #18548 (and assign it to you). I'm doing 3.4 and 3.5 because we want to expedite them for the releases.
/retitle [main] Bump go toolchain to 1.23.1
Thanks for the pull request, @ah8ad3. IMO, this change makes more sense in its own context than in the other pull request. Looking at the test failure, it seems like...
Covered during our triage meeting. @ah8ad3, are you looking into doing Benjamin's suggestion? Or should we close this pull request?